Fixes #95 Add EPEL GPG Key and logic to handle yum::gpgkeys #96
Conversation
| ## osfamily: RedHat | ||
|
|
||
| yum::gpgkeys: | ||
| /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-6: # https://archive.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-6 |
There was a problem hiding this comment.
This will install the EPEL gpg key on osfamily RedHat even if epel is not enabled ? That seems undesirable.
There was a problem hiding this comment.
Actually, that is just the key in hieradata. It works similar to the "repos" and "managed_repos" logic. In order for a gpg key to be added to the system, a repo specifically referencing that key must be included in the managed_repos list. It does not simply "create_resources()" for each gpgkey in gpgkeys. So, this specific key will not be added to the system, unless you have epel in manged_repos on an EL6 system (ceteris paribus).
|
While the merge request is fine technically do we really want to maintain GPG keys here? |
|
The gpgkey URL would be OK, for Internet connected machines, but in my case I need the content in hieradata. The only reason that we get away with specifying the file alone with the other repos is that the os-release package creates those files with the keys. However, you are the first person who has responded in nearly a month... so, if that is all that is holding up this request, then lets change the module-level hieradata to point to the URL and I can put the "content" in my own heiradata so we can get this pulled :) ~tommy |
traylenator
added
enhancement
|
I think this is fine since we can provide source and/or content. Since nobody else mentioned objections I'm going to merge this. |
Pull Request (PR) description
Add the EPEL GPG key for EL6 and EL7, and adding the logic to automatically include GPG Keys from the yum::gpgkeys hash, including tests and some basic docs.
This Pull Request (PR) fixes the following issues
Fixes #95